Set return type to None for functions without returns#581
Merged
ccordoba12 merged 4 commits intopython-lsp:developfrom Jul 29, 2024
agserrano3:codegen/epic/2205/task/88650/solve/25068
Merged
Set return type to None for functions without returns#581ccordoba12 merged 4 commits intopython-lsp:developfrom agserrano3:codegen/epic/2205/task/88650/solve/25068
None for functions without returns#581ccordoba12 merged 4 commits intopython-lsp:developfrom
agserrano3:codegen/epic/2205/task/88650/solve/25068
Conversation
Member
|
Hey @agserrano3, thanks for your contribution! Overall, it looks good to me so kudos to you and @bagel897 on the work you're doing at Codegen! Please rebase or merge with |
Contributor
Author
|
thanks for you review @ccordoba12 , I have now solved the conflicts |
ccordoba12
approved these changes
Jul 29, 2024
Member
ccordoba12
left a comment
ccordoba12
left a comment
There was a problem hiding this comment.
Thanks for your contribution @agserrano3!
ccordoba12
changed the title
None for functions without returns
ccordoba12
changed the title
None for functions without returnsNone for functions without returns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Hi there!
I'm Toni García, a colleague of @bagel897. Together, we're committed to improving code quality through automatically generated codemods. Our mission is to help maintain high standards by automating issue detection and resolution. 🔍✨
🎉 We're excited to start collaborating with your team! In our upcoming PRs, you can expect to see:
These changes aim to be low-effort for the maintainers but highly effective in keeping the codebase clean and efficient.
🔧 For this first PR, we've focused on enhancing code clarity by adding explicit return types for Python methods that do not return anything. This small change helps improve readability and maintainability of the code. 💡
📬 FAQ
If you encounter any issues with the PR or want to discuss anything further, feel free to email me at toni@codegen.com. I'm always here to help and happy to talk to a human! 🙋♂️
Codegen unleashes the power of ⚡ GPT-4 code mods ⚡, fully integrated into your development workflow.
Learn more
Looking forward to your feedback and collaboration!
Cheers, Toni and Ellen